Updated Sector Display & Expanded Scenario Information #5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `JComboBox` with `JList` for track selection to improve usability and accommodate future enhancements. Updated layout and constraints to maintain alignment and visual consistency across components. Adjusted related methods to support the new list-based approach and ensured existing functionality is preserved.
Removed unnecessary logger instances and refactored method calls for clarity and performance improvement in StratconTab and StratconPanel. Simplified the code by using static imports for ForceAlignment constants, enhancing readability and maintainability. Additionally, updated the `buildSelectedHexInfo` method to include the `campaign` parameter for more accurate data handling.
|
Also, I hate GUI work. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .append("<br/>"); | ||
| } | ||
|
|
||
| if (campaign != null) { | ||
| AtBDynamicScenario backingScenario = getBackingScenario(); |
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5292 +/- ##
============================================
- Coverage 10.47% 10.47% -0.01%
- Complexity 6049 6055 +6
============================================
Files 959 959
Lines 135202 135498 +296
Branches 19674 19739 +65
============================================
+ Hits 14165 14189 +24
- Misses 119686 119953 +267
- Partials 1351 1356 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the StratCon sector display to display a list of sectors, rather than using a drop-down. This makes it easier for users to spot how many sectors they are assigned to, for any given contract.
I also went ahead and expanded the scenario information to include ally (including player) and hostile (including 3rd parties) BV. This should make it easier for users to determine what forces to assign to what scenario without needing to bounce between the AO and Briefing tabs quite as much.
Players currently on Integrated contracts, when updating, will notice a minor visual bug where things don't use the best alignment. It's very minor and doesn't break anything. This bug will not exist for campaigns that pick Integrated contracts after updating.