Added Recalculation of Scenario Objectives when Assigning Forces #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserted a call to `translateTemplateObjectives` in the `StratconScenarioWizard` class for better handling of scenario objectives. This ensures objectives are updated when assigning forces.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5290 +/- ##
=========================================
Coverage 10.47% 10.48%
- Complexity 6065 6067 +2
=========================================
Files 959 959
Lines 135505 135515 +10
Branches 19742 19743 +1
=========================================
+ Hits 14199 14202 +3
- Misses 119953 119957 +4
- Partials 1353 1356 +3 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 3, 2024
|
@IllianiCBT Merge Conflicts |
# Conflicts: # MekHQ/src/mekhq/gui/stratcon/StratconScenarioWizard.java
# Conflicts: # MekHQ/src/mekhq/gui/stratcon/StratconScenarioWizard.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserted a call to
translateTemplateObjectivesin theStratconScenarioWizardclass for better handling of scenario objectives. This ensures objectives are updated when assigning forces.Closes #5288