Refactored Strategic Formations #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the strategic formation handling within the campaign code by introducing a centralized recalculation method to improve efficiency and consistency. Removed redundant checks and added sanitization for ineligible formations to maintain data integrity. This change also improved the logic for interacting with strategic formations, reducing duplicated code and enhancing readability.
Revised the `recalculateStrategicFormations` method to improve clarity and efficiency by adding separate sub-force calculations. Updated campaign processing to ensure strategic formation status is recalculated consistently. Integrated logging for better traceability of strategic formation eligibility and status updates.
jslater89
reviewed
Dec 1, 2024
Revised the method for recalculating strategic formations to optimize the handling of existing and new formations within a campaign. The update includes checking the eligibility of formations and adjusting the strategy status dynamically. Additionally, a method was added to remove non-eligible formations from the campaign's strategic structures.
Replaced several method names for better clarity and consistency, such as changing `importStrategicFormation` to `addStrategicFormation`. Updated calls to fetch and manipulate strategic formations with new methods, improving code readability and maintainability.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @return the sanitized {@link Hashtable} of {@link StrategicFormation} objects stored in the | ||
| * current campaign. | ||
| */ | ||
| public Hashtable<Integer, StrategicFormation> getStrategicFormationsTable() { |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5268 +/- ##
=========================================
Coverage 10.47% 10.47%
- Complexity 6039 6044 +5
=========================================
Files 959 959
Lines 135067 135115 +48
Branches 19650 19657 +7
=========================================
+ Hits 14147 14154 +7
- Misses 119569 119612 +43
+ Partials 1351 1349 -2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of refactoring for the new Strategic Formations system. It bolsters existing methods with a few extra calls and integrates better across MHQ. This includes self-sanitizing methods and a centralized way to review the TO&E to ensure it's always up-to-date. A number of bugs have been resolved and the general user experience has been improved.