Refactored Scenario Force Building Logic. #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised force composition logic to ensure proper handling of transporter units and their transportees, preventing stranding issues. Introduced helper methods for calculating battle values and fallback force composition. Improved how we cull units further, to hopefully prevent issues where entire forces are silently culled.
IllianiCBT
added
the
Force Generation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5264 +/- ##
=========================================
Coverage 10.47% 10.48%
- Complexity 6039 6048 +9
=========================================
Files 959 959
Lines 135067 135101 +34
Branches 19650 19660 +10
=========================================
+ Hits 14147 14160 +13
- Misses 119569 119595 +26
+ Partials 1351 1346 -5 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised force composition logic to ensure proper handling of transporter units and their transportees, preventing stranding issues. Introduced helper methods for calculating battle values and fallback force composition. Improved how we cull units further, to hopefully prevent issues where entire forces are silently culled.
Closes #5262