New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2: Refit Refit #5178

Draft

WeaverThree wants to merge 55 commits into MegaMek:master from WeaverThree:wvr-refit-pub

Draft

R2: Refit Refit #5178

Merge branch 'master' into wvr-refit-pub

GitHub Advanced Security / CodeQL failed Dec 6, 2024 in 9s

17 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

1 high

Other Alerts:

2 errors
8 warnings
6 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 192 in MekHQ/src/mekhq/campaign/parts/CASE.java

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

Check failure on line 104 in MekHQ/src/mekhq/campaign/parts/Refit.java

Code scanning / CodeQL

Container contents are never accessed Error

The contents of this container are never accessed.

Check failure on line 105 in MekHQ/src/mekhq/campaign/parts/Refit.java

Code scanning / CodeQL

Container contents are never accessed Error

The contents of this container are never accessed.

Check notice on line 1104 in MekHQ/src/mekhq/campaign/parts/Refit.java

Code scanning / CodeQL

Javadoc has impossible 'throws' tag Note

Javadoc for begin claims to throw EntityLoadingException but this is impossible.

Check notice on line 1719 in MekHQ/src/mekhq/campaign/parts/Refit.java

Code scanning / CodeQL

Javadoc has impossible 'throws' tag Note

Javadoc for saveCustomization claims to throw EntityLoadingException but this is impossible.

Check notice on line 2084 in MekHQ/src/mekhq/campaign/parts/Refit.java

Code scanning / CodeQL

Unread local variable Note

Variable 'int oldCrew' is never read.

Check failure on line 65 in MekHQ/src/mekhq/campaign/parts/RefitKit.java

Code scanning / CodeQL

Implicit narrowing conversion in compound assignment High

Implicit cast of source type double to narrower destination type

int

Check notice on line 117 in MekHQ/src/mekhq/campaign/parts/RefitKit.java

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

Part.getDetails

; it is advisable to add an Override annotation.

Check notice on line 258 in MekHQ/src/mekhq/campaign/parts/RefitStep.java

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 12 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.

Check warning on line 719 in MekHQ/src/mekhq/campaign/parts/RefitStep.java

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.

Check warning on line 719 in MekHQ/src/mekhq/campaign/parts/RefitStep.java

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.

Check warning on line 725 in MekHQ/src/mekhq/campaign/parts/RefitStep.java

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.

Check warning on line 735 in MekHQ/src/mekhq/campaign/parts/RefitStep.java

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.
Variable

newPart

may be null at this access as suggested by

this

null guard.

Check warning on line 922 in MekHQ/src/mekhq/campaign/parts/RefitStep.java

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.

Check warning on line 937 in MekHQ/src/mekhq/campaign/parts/RefitStep.java

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.
Variable

oldPart

may be null at this access as suggested by

this

null guard.

Check warning on line 1292 in MekHQ/src/mekhq/campaign/unit/Unit.java

Code scanning / CodeQL

Expression always evaluates to the same value Warning

Expression always evaluates to the same value.

Check warning on line 1298 in MekHQ/src/mekhq/campaign/unit/Unit.java

Code scanning / CodeQL

Expression always evaluates to the same value Warning

Expression always evaluates to the same value.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

R2: Refit Refit #5178

R2: Refit Refit #5178

17 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Annotations

Re-running checks...

R2: Refit Refit #5178

Are you sure you want to change the base?

Merge branch 'master' into wvr-refit-pub

R2: Refit Refit #5178

17 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Annotations

Re-running checks...