FG3 Scenario Improvements #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the `allowedUnitType` in LiaisonGround.xml from `9` to `0` to adjust the permitted units for scenarios. This modification ensures that the unit restrictions align with current scenario requirements.
Updated the time limit scale factor from 2 to 1 in various scenario templates to ensure consistency. Also corrected a misformatted description in the Deep Raid Defense scenario template.
Revised time limit properties to be scaled to the primary unit count instead of using a fixed value. This change affects the DropShip Raid, Deep Raid, and related defense scenario templates.
Increased the timeLimitScaleFactor from 1 to 2 in both Deep Raid and Deep Raid Defense scenario templates. This change ensures more scaled time limits based on primary unit count, improving game balance and difficulty.
IllianiCBT
added
Bug
Force Generation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5120 +/- ##
============================================
- Coverage 10.54% 10.53% -0.01%
+ Complexity 6040 6035 -5
============================================
Files 956 956
Lines 134181 134213 +32
Branches 19481 19489 +8
============================================
- Hits 14144 14139 -5
- Misses 118693 118729 +36
- Partials 1344 1345 +1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5118 && #5117