Fixed New Day Reporting #5077
Merged
Fixed New Day Reporting #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected whitespace and formatting inconsistencies within various methods in the `Campaign` class. Added triggering of `NewDayEvent` at the start of each new day cycle, instead of the end.
The gender parameter was passed incorrectly, causing issues with randomization. Changed the Gender.RANDOMIZE to use the variable 'gender' for proper assignment.
|
I'm tentatively hoping this will also fix the 'double-nag' bug. But only time will tell. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5077 +/- ##
============================================
+ Coverage 10.42% 10.43% +0.01%
- Complexity 6028 6039 +11
============================================
Files 953 953
Lines 134113 134123 +10
Branches 19435 19438 +3
============================================
+ Hits 13979 13996 +17
+ Misses 118785 118783 -2
+ Partials 1349 1344 -5 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected whitespace and formatting inconsistencies within various methods in the
Campaignclass. Added triggering ofNewDayEventat the start of each new day cycle, instead of the end.Also fixed a couple of minor issues in campaign.java that weren't worth their own PR.
Closes #4998