Updated Primary Allies Scenario Modifiers #5074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two primary allies modifiers are a special case that is randomly added to a scenario, based on the contract command level (or contract type)...
![image](https://private-user-images.githubusercontent.com/103902653/378127456-d451a88f-1236-4dba-977a-4b7cce8e35c7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDY5NjksIm5iZiI6MTczOTYwNjY2OSwicGF0aCI6Ii8xMDM5MDI2NTMvMzc4MTI3NDU2LWQ0NTFhODhmLTEyMzYtNGRiYS05NzdhLTRiN2NjZThlMzVjNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwODA0MjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xZGI4OGE3MjE0ZTE4ZjFkOTNjN2Y0MWZjMjcxMjFiN2EzNDNiZDk2MTIzNjM5YjQ2OGE3OGUxN2E1YTI3MTNkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.o92ELt_bOAzE3t1KcL7F3dxMu5pD-wuxkOYA02gzQ9s)
...this runs contrary to the modifiers' description which made it seem like mhq was reacting to the size of enemy forces.
Instead, this modifier would increase the size of the OpFor (by increasing the size of the player-allied force), resulting in the 'overwhelming enemy forces' problem it was claiming to 'solve'.
This PR restores the ability for these modifiers to contribute to BV (that had been accidentally dropped some time around 50.0) and updates the modifier description. While the original description was well intentioned, and technically accurate, it contributed to a lot of confusion over the months whenever Force Generation and balancing were being discussed.
Closes #5008