Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Primary Allies Scenario Modifiers #5074

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

IllianiCBT
Copy link
Collaborator

The two primary allies modifiers are a special case that is randomly added to a scenario, based on the contract command level (or contract type)...
image
...this runs contrary to the modifiers' description which made it seem like mhq was reacting to the size of enemy forces.

Instead, this modifier would increase the size of the OpFor (by increasing the size of the player-allied force), resulting in the 'overwhelming enemy forces' problem it was claiming to 'solve'.

This PR restores the ability for these modifiers to contribute to BV (that had been accidentally dropped some time around 50.0) and updates the modifier description. While the original description was well intentioned, and technically accurate, it contributed to a lot of confusion over the months whenever Force Generation and balancing were being discussed.

Closes #5008

Updated briefing text for clarity and adjusted flags, so allied units now contribute to BV and unit count.
@IllianiCBT IllianiCBT added Bug Force Generation Anything related to Force Generation (Opfor or Friendly) labels Oct 19, 2024
@IllianiCBT IllianiCBT self-assigned this Oct 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.41%. Comparing base (a339462) to head (52bc6e7).
Report is 113 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5074      +/-   ##
============================================
- Coverage     10.42%   10.41%   -0.01%     
+ Complexity     6028     6025       -3     
============================================
  Files           953      953              
  Lines        134113   134121       +8     
  Branches      19435    19437       +2     
============================================
- Hits          13979    13974       -5     
- Misses       118785   118801      +16     
+ Partials       1349     1346       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 5c290ac into MegaMek:master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Force Generation Anything related to Force Generation (Opfor or Friendly)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.01-SNAPSHOT] PrimaryAlliesGround.xml modifier occurring even after opfor bids down to match player BV
3 participants