Added 'No Eligible Personnel' Dialog to Turnover & Retention Checks #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant visibility and location setting for RetirementDefectionDialog in multiple classes and set it to always be on top within the dialog initialization. This ensures the dialog appears correctly without requiring additional location settings.
Updated RetirementDefectionDialog to use UIUtil.scaleForGUI for setting dialog dimensions to ensure consistency with other UI components and improve scaling across different display settings. This change helps maintain a uniform look and feel in the application’s UI.
Implemented a check in RetirementDefectionDialog to display a notification when no personnel are eligible for retirement or defection. This includes a new dialog with a message and an OK button to acknowledge the notification.
Renamed the variable 'rdd' to 'dialog' for better readability and consistency across the BriefingTab and CampaignGUI classes. This change helps to maintain code clarity and aids in understanding the purpose of the variable more intuitively.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5068 +/- ##
============================================
- Coverage 10.43% 10.42% -0.02%
- Complexity 6032 6033 +1
============================================
Files 952 953 +1
Lines 133878 134123 +245
Branches 19436 19435 -1
============================================
+ Hits 13976 13982 +6
- Misses 118560 118792 +232
- Partials 1342 1349 +7 ☔ View full report in Codecov by Sentry. |
|
Oh nice. The c-bill icon to make the dialog not too tiny is a nice touch :D |
HammerGS
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when users are prompted to make a turnover check the turnover table will only show characters with a TN greater than 2. This means that often the table will appear empty, creating confusion among users. This is especially true for early campaigns, when all personnel are benefiting from employment contract bonuses.
Now, if nobody is eligible for turnover, a dialog will replace the turnover table informing users of this. It is not possible to skip the turnover dialog entirely, as the prompt does not know that the table is empty when it is triggered.
The image shown in the dialog will change to match the campaign faction, where possible.
Closes #5059