-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parts - minor refactoring and better information #5066
Parts - minor refactoring and better information #5066
Conversation
…tory so get rid of it
I'll sort out the failed test after this headache x.x |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5066 +/- ##
==========================================
Coverage 10.42% 10.43%
- Complexity 6033 6037 +4
==========================================
Files 953 953
Lines 134106 134264 +158
Branches 19434 19456 +22
==========================================
+ Hits 13986 14004 +18
- Misses 118772 118917 +145
+ Partials 1348 1343 -5 ☔ View full report in Codecov by Sentry. |
I fixed the tests for the new format of MekLocation details (mainly, adding tons and leaving off damage unless damaged). This also led me to some other errors I had made with that one, which are now fixed. I also realized that I had not gotten to PodSpace's getDetails, and I also stumbled into something that regexes the resulting string in TaskTableModel, so I'm not touching that for now. I haven't played with omnimechs and I do not understand how pods work very well from my experiments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about the systems being touched to review this. So it might be in the queue for a little longer than normal.
Found one thing I missed, mek locations need to show their repair costs as well. Not that these values are relevant to any game situations given the scale of money, all parts should show it if they have it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to work.
This is a fairly hefty scrub and tuning of campaign/parts/*.java, particularly the string and UI-related bits. It fixes a number of minor bugs and nuisances as it goes.
Original Goal:
Major points:
Along the way:
There isn't a whole lot to see but here are a few examples of stuff that you can: