Parts In Use - Filter Mothballed and Spare Part Quality #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MekHQ/src/mekhq/campaign/universe/generators/companyGenerators/AbstractCompanyGenerator.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5055 +/- ##
============================================
- Coverage 10.44% 10.42% -0.02%
+ Complexity 6039 6033 -6
============================================
Files 953 953
Lines 133945 134106 +161
Branches 19431 19434 +3
============================================
- Hits 13990 13986 -4
- Misses 118611 118772 +161
- Partials 1344 1348 +4 ☔ View full report in Codecov by Sentry. |
5 tasks
|
#5052 was merged so I foded master back into this so it only shows relevant changes now |
IllianiCBT
requested changes
Oct 17, 2024
IllianiCBT
requested changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #5052 - the changes should look much smaller once that one is applied.
Implements #5026.
Adds options to the Parts In Use dialog to ignore parts on mothballed units and/or ignore spare parts under a given quality. The latter will be much more useful once we get random part quality implemented, but I decided to cut this out as a complete unit before then since it's all UI.
It also makes the dialog a little bigger and tweaks the sizes of columns a little, since I find this window needs fiddling with every time it's opened, hopefully this will lessen that.
Example Images: