-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple FG3 Improvements #5042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced logging to provide detailed insights during force generation. Optimized force generation logic by introducing planetary and weather condition checks. Simplified code with switch expressions and added a second chance entity generation mechanism.
Fixed line breaks in briefing text for multiple scenario XML files for consistency. Updated several scenario modifiers to contribute correctly to BV and unit counts. Commented out some unused modifiers in airBattleModifiers.xml and groundBattleModifiers.xml.
Condensed descriptions in "Frontline Disruption" and modified generationMethod in "DropShip Raid." Removed redundant objectives in "Heavy Recon Evasion" and adjusted time limit settings for better gameplay balance.
Removed redundant scenario and contract details from bid away and supplement force reports to streamline the messages. Also deleted unnecessary concluding text from the batchall process. This improves readability and maintains focus on the essential information.
Moved the processNewDayATBScenarios call to an earlier point in the day transition method. This ensures new scenarios are processed before any contracts are evaluated. Additionally, removed the redundant check for being on a planet when initiating contracts.
This was referenced Oct 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5042 +/- ##
=========================================
Coverage 10.43% 10.43%
- Complexity 6022 6028 +6
=========================================
Files 952 952
Lines 133810 133893 +83
Branches 19432 19434 +2
=========================================
+ Hits 13961 13972 +11
- Misses 118498 118579 +81
+ Partials 1351 1342 -9 ☔ View full report in Codecov by Sentry. |
The code to adjust the BV and unit count for enemy bot forces was removed as it was redundant. This adjustment was not utilized elsewhere in the code and was unnecessary for the logic flow.
HammerGS
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5041 && #5005 && #5009 && #5027