Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hiring halls from clan worlds #4961

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Oct 1, 2024

This PR updates the dynamic hiring hall formula to remove hiring halls for systems owned by the clans. This was due to a discussion in Discord where the consensus was that having hiring halls was inconsistent with clan lore.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.45%. Comparing base (1706145) to head (98ed721).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4961   +/-   ##
=========================================
  Coverage     10.44%   10.45%           
- Complexity     6004     6013    +9     
=========================================
  Files           951      951           
  Lines        132875   132877    +2     
  Branches      19329    19330    +1     
=========================================
+ Hits          13884    13891    +7     
+ Misses       117643   117637    -6     
- Partials       1348     1349    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit d074c65 into MegaMek:master Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants