Fixed Personnel Filter Role Checks to For Vehicle and Vessel Crews #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing the big merge the other day, we accidentally used isVesselCrew/isVehicleCrew instead of isVesselCrewMember/isVehicleCrewMember
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4939 +/- ##
=========================================
Coverage 10.44% 10.44%
- Complexity 5998 6005 +7
=========================================
Files 951 951
Lines 132874 132875 +1
Branches 19329 19329
=========================================
+ Hits 13873 13883 +10
+ Misses 117653 117638 -15
- Partials 1348 1354 +6 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing the big merge the other day, we accidentally used
isVesselCrew/isVehicleCrewinstead ofisVesselCrewMember/isVehicleCrewMember###Closes #4900