Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Batchall Logic and Enhanced Bidding Report #4924

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Centralized Batchall faction list and ensured consistent checking throughout the codebase. Improved the reporting mechanism by differentiating between strict, opportunistic, and liberal honor levels, and added more informative logging to the bidding process. Added a fun Easter Egg for non-Clan factions encountering the Clans for the first time prior to the Outreach Summit of January 3051.

Centralized Batchall faction list and ensured consistent checking throughout the codebase. Improved the reporting mechanism by differentiating between strict, opportunistic, and liberal honor levels, and added more informative logging to the bidding process. Added a fun Easter Egg for non-Clan factions encountering the Clans for the first time prior to the Outreach Summit of January 3051.
@IllianiCBT IllianiCBT self-assigned this Sep 27, 2024
@IllianiCBT
Copy link
Collaborator Author

Forgot to include these changes:

  • Rebalanced Clan bidding thresholds
  • Changed the post-invasion doctrine change dates to better reflect lore (previously we just used the end of the CI era year)
  • Shored up a few logic checks
  • Added better log entries when verbose logging is disabled.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.44%. Comparing base (b8b9400) to head (90ea1b7).
Report is 44 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4924      +/-   ##
============================================
- Coverage     10.45%   10.44%   -0.02%     
+ Complexity     6008     5998      -10     
============================================
  Files           952      951       -1     
  Lines        132759   132874     +115     
  Branches      19309    19329      +20     
============================================
- Hits          13885    13873      -12     
- Misses       117518   117653     +135     
+ Partials       1356     1348       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 6f7238a into MegaMek:master Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants