Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Award Drawing Methods #4883

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

IllianiCBT
Copy link
Collaborator

Replaced stream-based award filtering and sorting with explicit loops for clearer logic. Adjusted image scaling to maintain aspect ratios using getScaledInstance instead of ImageHelpers. This change enhances code readability and ensures consistent image scaling.

Closes #4748

Added color-coded messaging to ensure random death events are highly noticeable to users. Imported necessary utilities and refined new day processing to utilize the enhanced reporting mechanism.
Replaced stream-based award filtering and sorting with explicit loops for clearer logic. Adjusted image scaling to maintain aspect ratios using `getScaledInstance` instead of `ImageHelpers`. This change enhances code readability and ensures consistent image scaling.
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (2ef3222) to head (259ff5a).
Report is 54 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4883      +/-   ##
============================================
- Coverage     10.31%   10.30%   -0.01%     
- Complexity     5872     5874       +2     
============================================
  Files           944      944              
  Lines        131403   131413      +10     
  Branches      19064    19070       +6     
============================================
  Hits          13548    13548              
- Misses       116539   116556      +17     
+ Partials       1316     1309       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 903f3fd into MegaMek:master Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Award dimensions not scaling at 87px square
3 participants