Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ConcurrentModificationException in Personnel Removal Process #4861

Conversation

IllianiCBT
Copy link
Collaborator

Fixed ConcurrentModificationException in Personnel Removal Process by streamlining the logic.

I am once again reminded that streams are not my friend.

Closes #4771 && #4781

Fixed `ConcurrentModificationException` in Personnel Removal Process by streamlining the logic.

I am once again reminded that streams are not my friend.
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues labels Sep 19, 2024
@IllianiCBT IllianiCBT self-assigned this Sep 19, 2024
@IllianiCBT
Copy link
Collaborator Author

Closing as resolved

@IllianiCBT IllianiCBT closed this Sep 19, 2024
@IllianiCBT IllianiCBT reopened this Sep 19, 2024
@IllianiCBT
Copy link
Collaborator Author

Whoops, wrong case. Reopening

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (752cc96) to head (33503ff).
Report is 118 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4861      +/-   ##
============================================
- Coverage     10.30%   10.30%   -0.01%     
- Complexity     5871     5874       +3     
============================================
  Files           944      944              
  Lines        131394   131407      +13     
  Branches      19063    19068       +5     
============================================
  Hits          13545    13545              
- Misses       116532   116544      +12     
- Partials       1317     1318       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 8bb32bb into MegaMek:master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Personnel Clean Up
3 participants