Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Post-Name Change Compatibility Handlers to SkillType.java #4847

Merged

Conversation

IllianiCBT
Copy link
Collaborator

Updated generateInstanceFromXML method to handle legacy skill names for backward compatibility.

Closes #4836

Updated `generateInstanceFromXML` method to handle legacy skill names for backward compatibility.
@IllianiCBT IllianiCBT added Bug Campaign Options Relates to, or includes, campaign option changes Compatibility An issue relating to compatibility between Milestones labels Sep 16, 2024
@IllianiCBT IllianiCBT self-assigned this Sep 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.31%. Comparing base (c1900ec) to head (bb64658).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4847      +/-   ##
============================================
+ Coverage     10.30%   10.31%   +0.01%     
- Complexity     5868     5881      +13     
============================================
  Files           944      944              
  Lines        131420   131429       +9     
  Branches      19061    19062       +1     
============================================
+ Hits          13538    13558      +20     
+ Misses       116567   116557      -10     
+ Partials       1315     1314       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 3e648e4 into MegaMek:master Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Campaign Options Relates to, or includes, campaign option changes Compatibility An issue relating to compatibility between Milestones
Projects
None yet
3 participants