Removed Ability to Assign AeroSpace Pilots to Conventional Aircraft

[IllianiCBT]

Removed unnecessary isAerospaceGrouping call to correct logic in isConventionalAirGrouping method. This ensures that only conventional aircraft pilots are considered as suitable for flying conventional aircraft.

The ability for aerospace (and by extension LAM) pilots to fly conventional aircraft was a legacy decision and does not match current rules.

I opted to just remove the ability for aerospace pilots to be assigned to new conventional aircraft, rather than including any handler for personnel currently assigned to conventional aircraft, as this was the easiest solution and required the least additional new code. It has the added benefit of allowing existing campaigns to be grandfathered in and has the least likelihood of breaking things.

Closes #4649

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.19%. Comparing base (454a4ea) to head (194a17f).
Report is 83 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4822      +/-   ##
============================================
- Coverage     10.61%   10.19%   -0.42%     
- Complexity     5655     5657       +2     
============================================
  Files           948      948              
  Lines        132553   132553              
  Branches      19048    19048              
============================================
- Hits          14072    13518     -554     
- Misses       117246   117800     +554     
  Partials       1235     1235              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[IllianiCBT]

Updated to account for the recent name change project