Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in camlann system faction ownership #4793

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Sep 5, 2024

There was an error in the faction ownership for the Camlann (FWL) system in 3148. I checked on Sarna and the owner at that time should be FWL, not "canon".

Closes #4765

Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.80%. Comparing base (3aae92e) to head (60a9445).
Report is 178 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4793   +/-   ##
=========================================
  Coverage     10.80%   10.80%           
  Complexity     5714     5714           
=========================================
  Files           950      950           
  Lines        131306   131306           
  Branches      19139    19139           
=========================================
  Hits          14193    14193           
  Misses       115886   115886           
  Partials       1227     1227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 17568c3 into MegaMek:master Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE on interstellar map
3 participants