Fix 4728: Safety getBay, add unit test, turn down logging in one location #4731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional anti-null check when getting the Bay name for a Part for a Unit that may not have its Entity set yet.
This info should be corrected later in the campaign loading process anyhow.
NOTE: the save file in #4728 did display missing/destroyed DS bay doors and cubicles on my system following this fix, but I was not able to repro that with a brand new save replicating the TOE layout. This save may be useful for replicating this bug in the future.
Testing:
Close #4728