Refactored Difficulty Multiplier Calculation #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the `getDifficultyMultiplier` method to use a switch expression based on skill levels. This change improves readability and allows for more granular control over the difficulty multipliers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4722 +/- ##
============================================
- Coverage 10.76% 10.20% -0.57%
+ Complexity 5668 5662 -6
============================================
Files 948 948
Lines 132553 132560 +7
Branches 19048 19048
============================================
- Hits 14272 13525 -747
- Misses 117041 117795 +754
Partials 1240 1240 ☔ View full report in Codecov by Sentry. |
|
Flipping this to live. @Thom293 when this gets merged you'll need to update your StratCon guide |
# Conflicts: # MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java
|
Updated to account for the recent name change project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged into 50.0
Revised the
getDifficultyMultipliermethod to use a switch expression based on skill levels. I also went ahead and adjusted the multipliers based on Discord feedback this means the difficulty campaign option will have a far larger impact on OpFor generation, especially when combined with my other two OpFor PRs.Below, I've included the percentage of the player's BV that will be used as base BV allowance when generating OpFors. The old values are in parentheses. As you can see, the impact of each difficulty is substantially larger than the old values. This should give players far better control over their experience and will mean that newer players won't get the pants kicked out of them as often, while veteran players will be able to enjoy the challenge they desire.
Ultra-Green: 50% (80%)
Green: 75% (90%)
Regular: 100% (100%)
Veteran: 125% (110%)
Elite: 150% (120%)
Heroic: 175% (130%)
Legendary: 200% (140%)