Revised CamOps Reputation Derived AtB Modifier, Renamed getUnitRatingMod Method
#4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated ELITE, HEROIC, and LEGENDARY levels into a single rating value. This change simplified the experience rating scale and ensured a more streamlined progression logic.
Changed all occurrences of the method `getUnitRatingMod()` to `getAtBUnitRatingMod()` across multiple classes. This was done to improve code clarity and consistency in handling unit rating modifications specific to the Against the Bot (AtB) functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4691 +/- ##
============================================
- Coverage 10.76% 10.07% -0.70%
+ Complexity 5668 5656 -12
============================================
Files 948 948
Lines 132553 132551 -2
Branches 19048 19048
============================================
- Hits 14272 13353 -919
- Misses 117041 117962 +921
+ Partials 1240 1236 -4 ☔ View full report in Codecov by Sentry. |
# Conflicts: # MekHQ/src/mekhq/campaign/Campaign.java # MekHQ/src/mekhq/campaign/againstTheBot/AtBConfiguration.java # MekHQ/src/mekhq/campaign/market/ContractMarket.java
|
This PR has been updated to include name changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated ELITE, HEROIC, and LEGENDARY levels into a single rating value. This more closely matches the values expected by AtB and will prevent unexpected behavior.
This PR also renames the
getUnitRatingModtogetAtBUnitRatingModto more closely match its' use. This touches a lot of Classes, making this PR look a lot scarier than it actually is.