Fixed NPE in CamOps Mission Date Calculation #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, mission date calculation could throw a NullPointerException if there were no missions. Added a null check to ensure `oldestMissionDate` defaults to the current date if no missions exist. This prevents the exception and ensures proper date calculation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4674 +/- ##
=========================================
Coverage 10.79% 10.80%
- Complexity 5710 5714 +4
=========================================
Files 950 950
Lines 131271 131277 +6
Branches 19135 19133 -2
=========================================
+ Hits 14177 14189 +12
+ Misses 115875 115863 -12
- Partials 1219 1225 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, mission date calculation could throw a NullPointerException if there were no missions. Added a null check to ensure
oldestMissionDatedefaults to the current date if no missions exist. This prevents the exception.