Fixed Intelligence XP Cost Calculations and Minor Logic Issues #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rounded XP costs to nearest integer to improve accuracy and consistency. Corrected handling of zero intelligence scores to avoid division anomalies and updated imports for cleaner code. These changes ensure more precise experience cost computations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4656 +/- ##
============================================
+ Coverage 10.65% 10.67% +0.01%
- Complexity 5702 5706 +4
============================================
Files 950 950
Lines 131271 131274 +3
Branches 19134 19135 +1
============================================
+ Hits 13988 14012 +24
+ Misses 116059 116038 -21
Partials 1224 1224 ☔ View full report in Codecov by Sentry. |
|
FWIW I've spent a couple hours testing this without seeing the old issues with XP, or any new ones. |
NickAragua
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rounded XP costs to nearest integer to improve accuracy and consistency. Corrected handling of zero intelligence scores to avoid division anomalies.
Closes #4653