Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement negotiation for salvage terms #4641

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Aug 15, 2024

This adds the ability for Admin/Logistics personnel to reroll salvage terms when negotiating AtB contracts. The plumbing was already in place--I mostly just had to add the UI elements.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.89%. Comparing base (cef4c6c) to head (8d78bff).
Report is 55 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4641      +/-   ##
============================================
- Coverage      9.90%    9.89%   -0.01%     
  Complexity     5676     5676              
============================================
  Files           945      945              
  Lines        129636   129663      +27     
  Branches      19092    19098       +6     
============================================
  Hits          12836    12836              
- Misses       115583   115610      +27     
  Partials       1217     1217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the tests pass, this is good to go.

@IllianiCBT IllianiCBT merged commit 3d32585 into MegaMek:master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants