Updated Person View and Personnel Tab to Better Support Differing Screen Sizes #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decreased the PERSONNEL_VIEW_WIDTH from 500 to 475 to improve layout. Replaced `firsty` and `secondy` with a single variable `y` for grid positioning to simplify code readability and maintainability.
Changed the PERSONNEL_VIEW_WIDTH constant from 475 to 500 in PersonnelTab.java. This adjustment allows for a slightly wider display area for personnel information, improving the user interface.
IllianiCBT
changed the title
Increased the preferred size of the personnel and view scroll tables to improve layout and visual presentation. Adjusted the dimensions to better fit the GUI design and user experience.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4597 +/- ##
============================================
- Coverage 10.31% 10.31% -0.01%
Complexity 5818 5818
============================================
Files 936 936
Lines 128889 128894 +5
Branches 18960 18961 +1
============================================
Hits 13301 13301
- Misses 114312 114317 +5
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Person View pane on the Personnel Tab by switching the number of biographic columns from 2 to 1. It also adjusts the Person View width both on the Personnel Tab and Personnel Market. This allows the associated tables to take up the bulk of the screen real estate, while also ensuring all the important information on the Person View is fully visible.
This PR should be particularly useful for users with unusually wide or narrow screens.
Closes #4433