Refactored Fixed Experience Level Person Generation in Bulk Recruitment #4590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the method by which we generate personnel at a fixed experience level during bulk recruitment. This was an option added a little while ago, but the implementation was... well, it wasn't great. Previously we looped until the right experience level was hit. This was possibly the most expensive way I could have accomplished the task and I've been looking for an excuse to redo it ever since it got merged.
Now, we just fetch the profession requested and then overwrite the randomized skill levels for that profession, replacing them with the fixed values. This is substantially quicker, and far more reliable than the earlier approach.
Closes #4579