Added Education Module Handler for Injured Personnel #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Injured personnel are no longer able to attend academies. Furthermore, the placeholder code included while education level was missing from new characters has been removed, as it is no longer necessary.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4563 +/- ##
============================================
- Coverage 10.32% 10.32% -0.01%
Complexity 5816 5816
============================================
Files 935 935
Lines 128792 128801 +9
Branches 18951 18950 -1
============================================
Hits 13296 13296
- Misses 114220 114229 +9
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Aug 8, 2024
# Conflicts: # MekHQ/src/mekhq/gui/adapter/PersonnelTableMouseAdapter.java
Simplified the logic for displaying the education menu by reorganizing the condition checks. The campaign variable is now stored before the checks to avoid multiple calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injured personnel are no longer able to attend academies. Furthermore, the placeholder code included while education level was missing from new characters has been removed, as it is no longer necessary.
Closes #4555