Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Turnover Target Number Method Configuration #4509

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Deleted the turnover target number method and related difficulty settings. Simplified turnover check logic to always use fixed target numbers directly without HR skill adjustments or difficulty modifiers.

Unfortunately, the Negotiation and Administration-tied turnover target number methods were resulting in a very poor play experience. This issue was fundamental and beyond my ability to resolve, so I opted to move to effectively only include the 'fixed' method as this provides the most balanced experience for all players, while still being easy to configure.

Deleted the turnover target number method and related difficulty settings. Simplified turnover check logic to use fixed target numbers directly without HR skill adjustments or difficulty modifiers.
@IllianiCBT IllianiCBT added Personnel Personnel-related Issues UX User experience labels Jul 28, 2024
@IllianiCBT IllianiCBT self-assigned this Jul 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.32%. Comparing base (0ecc4a0) to head (90fc1b4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4509      +/-   ##
============================================
- Coverage     10.33%   10.32%   -0.01%     
+ Complexity     5824     5812      -12     
============================================
  Files           935      934       -1     
  Lines        128395   128272     -123     
  Branches      18889    18867      -22     
============================================
- Hits          13270    13249      -21     
+ Misses       113849   113747     -102     
  Partials       1276     1276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit cc1e80c into MegaMek:master Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants