Added Ability to Tell autoAwards to Ignore Individual Custom Award Sets #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new field `awardSetFilterList` in `CampaignOptions` for filtering award sets in autoAwards. Updated related GUI components and serialization methods to manage this new option. Enhanced `AutoAwardsController` to respect the filter list during award set processing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4493 +/- ##
============================================
- Coverage 10.31% 10.31% -0.01%
- Complexity 5813 5814 +1
============================================
Files 934 934
Lines 128441 128474 +33
Branches 18910 18912 +2
============================================
+ Hits 13253 13256 +3
- Misses 113912 113942 +30
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces another long requested feature: the ability to filter award sets so that autoAwards won't use specific custom award sets. This is as simple as entering the names of the award sets you don't want autoAwards to use into a free text box in campaign options. As it runs autoAwards will check whether an award set appears in that list, and if it does it will ignore all awards from that set.