Fixed Missing Site Location Change Code & Turnover Information Storage #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected a bug in the handling of leased large mech dropships where the integer part of mech reduction was not properly cast. Also fixed incorrect cumulative cargo capacity to ensure accurate leasing operations.
Updated several logging statements to use placeholders {} instead of string concatenation for better performance and readability. Also changed an equality check to use Objects.equals() to handle potential null values safely.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4490 +/- ##
============================================
- Coverage 10.33% 10.33% -0.01%
+ Complexity 5824 5823 -1
============================================
Files 935 935
Lines 128395 128391 -4
Branches 18889 18891 +2
============================================
- Hits 13270 13268 -2
+ Misses 113849 113846 -3
- Partials 1276 1277 +1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I managed to accidentally all but wipe #4462 prior to it getting merged. It's definitely a case of error between keyboard and chair, but either way, this PR restores the code.
Furthermore, an oversight in the storing of turnover results across days caused it to never be forgotten so users would get spammed with their turnover results every day. On the bright side, this means it was currently storing the information across new day events! Not ideal though, so this PR also fixes that.
I also spotted that the leasing of DropShips was using a lossy implicit cast in a number of places, so I corrected that. DropShip need calculations should now be a little more accurate. Eventually we probably want to move this from
Campaign.javaand give it a full review to make sure everything is being handled correctly. Especially as some of this code hasn't been touched for 7 years.