Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Window Closing Event to PersonnelMarketDialog #4461

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

IllianiCBT
Copy link
Collaborator

A WindowAdapter was added to the PersonnelMarketDialog class, which triggers an update to paid recruitment when the window is closed.

This action, closeOrCancelActionPerformed(), was extracted from btnCloseActionPerformed() to be reusable. This method ensures that certain cleanup activities are performed whether the dialog is closed via the close button or by manually closing the window. Previously, they would only run when the window was closed via the close button.

Closes #4335

A WindowAdapter was added to the PersonnelMarketDialog class, which triggers an update to paid recruitment when the window is closing. This action, `closeOrCancelActionPerformed()`, was extracted from `btnCloseActionPerformed()` to be reusable. This method ensures that certain cleanup activities are performed whether the dialog is closed via the close button or by manually closing the window.
@IllianiCBT IllianiCBT added AtB Personnel Personnel-related Issues GUI Finances labels Jul 22, 2024
@IllianiCBT IllianiCBT self-assigned this Jul 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.24%. Comparing base (7ee9b9c) to head (c8ddbc7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4461      +/-   ##
============================================
- Coverage     10.24%   10.24%   -0.01%     
  Complexity     5809     5809              
============================================
  Files           925      925              
  Lines        126456   126462       +6     
  Branches      18770    18770              
============================================
  Hits          12953    12953              
- Misses       112228   112234       +6     
  Partials       1275     1275              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT added the Bug label Jul 22, 2024
@IllianiCBT IllianiCBT merged commit 217d886 into MegaMek:master Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paid recruitment doesnt turn off
3 participants