Added 'Unable to Afford Expenses' Nag Dialog #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new nag warning was added to alert the user when they cannot afford to cover all upcoming expenses at the end of the month. This was done by creating a new dialog box and implementing the appropriate checks and triggers at the necessary points.
# Conflicts: # MekHQ/resources/mekhq/resources/GUI.properties # MekHQ/src/mekhq/MHQConstants.java # MekHQ/src/mekhq/gui/dialog/MHQOptionsDialog.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4459 +/- ##
============================================
- Coverage 10.33% 10.22% -0.12%
+ Complexity 5819 5808 -11
============================================
Files 931 926 -5
Lines 128026 126710 -1316
Branches 18847 18824 -23
============================================
- Hits 13228 12951 -277
+ Misses 113522 112483 -1039
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 23, 2024
# Conflicts: # MekHQ/src/mekhq/gui/CampaignGUI.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new nag warning was added to alert the user when they cannot afford to cover all upcoming expenses at the end of the month. This was done by creating a new dialog box and implementing the appropriate checks and triggers at the necessary points.
This was added out of a sense of fairness. With the introduction of dynamic loyalty changes - and soon CamOps Morale - we will be punishing users for failing to pay their personnel. It seems only right that we offer a warning prior to kicking them in the shins.