Updated Divorce and Death Handling #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `Person` class, when a person's status was updated to 'Dead', checks were added to determine if the person has living children. If the person had children and no living parents remain, the children are logged as orphans.
Enhanced the way the game handles the death of a character within a relationship. Introduced comprehensive checks and notifications for the status of family members upon a character's death, including living spouses, children, and parents. Logs were also updated to differentiate between 'divorced' and 'widowed'.
IllianiCBT
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4440 +/- ##
============================================
- Coverage 10.24% 10.23% -0.01%
Complexity 5809 5809
============================================
Files 925 925
Lines 126459 126513 +54
Branches 18769 18784 +15
============================================
+ Hits 12953 12954 +1
- Misses 112231 112284 +53
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 23, 2024
# Conflicts: # MekHQ/src/mekhq/campaign/Campaign.java
# Conflicts: # MekHQ/resources/mekhq/resources/Personnel.properties # MekHQ/src/mekhq/campaign/personnel/Person.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the way the game handles the death of a character within a relationship. Introduced comprehensive checks and notifications for the status of family members upon a character's death, including living spouses, children, and parents. Logs were also updated to differentiate between 'divorced' and 'widowed'.
Closes #4323