Mark Medical settings as unofficial #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing any of the options in this section contradicts the rules provided in the fourth printing of Campaign Operations, so they should be distinguished from optional-but-official rules.
HammerGS
approved these changes
Jul 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4414 +/- ##
=========================================
Coverage 10.26% 10.26%
Complexity 5809 5809
=========================================
Files 924 924
Lines 126223 126223
Branches 18698 18698
=========================================
Hits 12952 12952
Misses 111996 111996
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially thought that MekHQ didn't implement the damage-tracking system Campaign Operations uses for infantry and vehicle crew, only to realize upon opening the code that it does. The confusion lies in the fact that those settings are not marked as unofficial even though changing them violates official rules.
Since I doubt I'm the only person to assume those were optional official rules, I'm updating the label.