Corrected Missing Fatigue Option Check During Scenario Resolution & for StratCon Actions #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in 'ResolveScenarioTracker.java' was updated to include a check whether the fatigue feature is enabled in the campaign options. If the fatigue feature is enabled, fatigue actions will be processed for the person object involved.
IllianiCBT
changed the title
The logic for calculating player fatigue was streamlined. This involved removing an unnecessary check in 'ResolveScenarioTracker.java', and moving a fatigue processing condition into an 'if' statement in 'StratconRulesManager.java' to ensure fatigue actions are only processed when the fatigue option is in use.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4405 +/- ##
=========================================
Coverage 10.27% 10.27%
Complexity 5811 5811
=========================================
Files 925 925
Lines 126031 126025 -6
Branches 18627 18628 +1
=========================================
Hits 12945 12945
+ Misses 111811 111805 -6
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in 'ResolveScenarioTracker.java' was updated to check whether fatigue is enabled in campaign options prior to triggering
Fatigue.processFatigueActions(). This bug was replicated inStratconRulesManagerso we've fixed it there too.