Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Execution and Jettison Options for Prisoners #4395

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Two new options for handling prisoners have been introduced: "execute" does what it says on the box, while "jettison" launches them into space.

The 'free' prisoner action has been limited to while the campaign is planet-side. To simulate that there isn't really anywhere to free people in the depths of space. Speaking of which...

'Jettison' is only available while the campaign is not planet-side.

Two new options for handling prisoners have been introduced to the MekHQ resources. "Execute" allows the user to kill a prisoner, while "Jettison" launches them into space.
@IllianiCBT IllianiCBT added the Personnel Personnel-related Issues label Jul 13, 2024
@IllianiCBT IllianiCBT self-assigned this Jul 13, 2024
@IllianiCBT IllianiCBT changed the title Added execution and jettison options for prisoners Added Execution and Jettison Options for Prisoners Jul 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.26%. Comparing base (f7bd31c) to head (6cc099e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4395      +/-   ##
============================================
- Coverage     10.27%   10.26%   -0.01%     
  Complexity     5811     5811              
============================================
  Files           925      925              
  Lines        126031   126048      +17     
  Branches      18627    18634       +7     
============================================
  Hits          12945    12945              
- Misses       111811   111828      +17     
  Partials       1275     1275              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IllianiCBT and others added 3 commits July 13, 2024 21:07
Two new options for handling prisoners have been introduced to the MekHQ resources. "Execute" allows the user to kill a prisoner, while "Jettison" launches them into space.
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work.

@HammerGS HammerGS added the Future Addition Required This tag indicates that additional rules or features would be useful for it. See notes. label Jul 14, 2024
@IllianiCBT IllianiCBT merged commit 9a09fcb into MegaMek:master Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Future Addition Required This tag indicates that additional rules or features would be useful for it. See notes. Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants