Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced CargoCapacityNagDialog functionality #4388

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

IllianiCBT
Copy link
Collaborator

This commit removed the CargoCapacityNagDialog functionality and all of its references. The cargo capacity report was redesigned to be more interactive, showing color-coded status directly in the Campaign Summary report. Users will no longer receive a dialog prompt when cargo capacity is exceeded, instead, they'll be visually prompted within the campaign statistics display, as shown below.

Within Capacity:
image

Cargo at Capacity:
image

Cargo Exceeds Capacity
image

(Actual colors dependent on MekHQ color options)

This implementation was my original intent, prior to writing the nag. However, at the time, I didn't have the knowledge necessary to get it to work so settled on a nag. That nag proved incredibly annoying, so has been removed.

This commit removed the CargoCapacityNagDialog functionality and all of its references. The cargo capacity report was redesigned to be more interactive, showing color-coded status directly in the Campaign Summary report. Users will no longer receive a dialog prompt when cargo capacity is exceeded, instead, they'll be visually prompted within the campaign statistics.
@IllianiCBT IllianiCBT self-assigned this Jul 12, 2024
@IllianiCBT IllianiCBT changed the title Removed CargoCapacityNagDialog functionality Replaced CargoCapacityNagDialog functionality Jul 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.27%. Comparing base (f7bd31c) to head (36b53d5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4388   +/-   ##
=========================================
  Coverage     10.27%   10.27%           
  Complexity     5811     5811           
=========================================
  Files           925      924    -1     
  Lines        126031   126031           
  Branches      18627    18628    +1     
=========================================
  Hits          12945    12945           
  Misses       111811   111811           
  Partials       1275     1275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work

@IllianiCBT IllianiCBT merged commit ea3a9dd into MegaMek:master Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants