Refactored Faction Restriction Checks in Academy Class #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redundant checks in the process of determining faction restrictions were simplified in the Academy class. The code was refactored to clarify the if conditions checks for faction restriction while also bundling the checks for origin and campaign factions together.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4384 +/- ##
=========================================
Coverage 10.27% 10.27%
Complexity 5810 5810
=========================================
Files 925 925
Lines 125985 125983 -2
Branches 18626 18625 -1
=========================================
Hits 12941 12941
+ Misses 111769 111767 -2
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redundant checks in the process of determining faction restrictions were simplified in the Academy class. The code was refactored to clarify the if conditions checks for faction restriction while also bundling the checks for origin and campaign factions together.
This resolves a bug, reported on the forums, where faction restriction wasn't working correctly due to faulty logic.