Expanded Manual Assignment of Personnel Statuses to Include PoW, On Leave, and AWOL Statuses
#4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PersonnelFilter for MIA status has been updated to also include Prisoners of War (PoWs). This change affects the GUI and various enum operations. The relevant tooltips in the GUI properties file have also been updated to reflect this change.
The previous logic was set to filter out the PersonnelStatus enumeration values that were PoW, on Leave, or AWOL in the getImplementedStatuses method. This has been altered to include all status enumerations without any filtering.
The switch-case statement in the 'testGetImplementedStatuses' method of PersonnelStatusTest.java has been condensed into a single assert statement.
IllianiCBT
changed the title
PoW, On Leave, and AWOL Statuses
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4377 +/- ##
============================================
- Coverage 10.27% 10.26% -0.01%
+ Complexity 5811 5807 -4
============================================
Files 925 925
Lines 126031 126029 -2
Branches 18627 18627
============================================
- Hits 12945 12943 -2
Misses 111811 111811
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
HammerGS
requested changes
Jul 14, 2024
HammerGS
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PersonnelFilter for the MIA status now includes friendly Prisoners of War (PoWs). The GUI properties file has been updated to reflect this change in the relevant text and tooltips. This decision was made to avoid creating an additional category and to reduce option clutter.
Additionally, I adjusted the
PersonnelStatus.getImplementedStatuses()method to no longer filter out theOn_Leave,AWOL, andPoWstatuses. These statuses were previously disabled as they were not implemented, but with ongoing expansions to the personnel modules, this is no longer the case. This allows users to manually assign these statuses to personnel.Although the PoW status will not be fully utilized until the S&E module is released later this year, it is now available for users to incorporate into their role-playing scenarios.