Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Education Level to Biographical Filter of Personnel Table #4373

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Jul 11, 2024

This PR adds Education Level to the Biographical Filter of the Personnel Table, replacing the 'Founder' column in that filter. Since the Founder flag is also available in the Flags filter, it didn't seem necessary to have it featured in two filters.

Additionally, this implementation includes Education Level in the personnel CSV export.

Closes #4317

Refactoring: I refactored PersonnelTableModelColumn.java to use the new enhanced switches introduced in j17

An "Education" field has been added to the PersonnelTableModelColumn in the MekHQ user interface. This field allows users to view and sort personnel by their highest level of education.
This commit replaces traditional switch-case statements with switch expressions in PersonnelTableModelColumn.java.
A new column named 'Education' has been added to the Personnel Table in the GUI properties of the MekHQ project.
@IllianiCBT IllianiCBT added the Personnel Personnel-related Issues label Jul 11, 2024
@IllianiCBT IllianiCBT self-assigned this Jul 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.27%. Comparing base (6b19b57) to head (3860687).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4373   +/-   ##
=========================================
  Coverage     10.27%   10.27%           
  Complexity     5810     5810           
=========================================
  Files           925      925           
  Lines        125978   125979    +1     
  Branches      18623    18622    -1     
=========================================
+ Hits          12941    12942    +1     
  Misses       111762   111762           
  Partials       1275     1275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 06a0ce5 into MegaMek:master Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Education status added as a sortable column
3 participants