Fixed Clan Creche Graduation in Education Module #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extended education condition to cover awaiting sibko assignment stage - Refactored graduationPicker call and following actions based on education stage - Removed TODO comments related to autoAwards linking in graduation methods - Added initial setEduEducationStage call in clearEducation method of Person class
IllianiCBT
changed the title
IllianiCBT
changed the title
SJuliez
approved these changes
Jun 4, 2024
| // is person on campus and undergoing education? | ||
| if (educationStage == 2) { | ||
| // is person on campus and undergoing education, or awaiting assignment to a sibko? | ||
| if ((educationStage == 2) || (educationStage == 3)) { |
There was a problem hiding this comment.
This would ideally be an enum like EducationStage.ON_CAMPUS, EducationStage.AWAITING_SIBKO
There was a problem hiding this comment.
Oh, good call! That never even occurred to me. I'll see it done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update resolves a typo in the clan creche graduation process. I also removed a number of 'TODO's that got missed by #4118.
This PR must be merged after #4118.