Fixed Friendly Personnel Missing Post-Scenario Scenario Credit #4125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where friendly personnel are not receiving scenario credit upon scenario completion.
From my analysis, it seems that friendly personnel should not be processed at this point in the code, as they are supposed to be handled elsewhere. I reviewed the code and could not identify where friendlies are being added to the
oppositionPersonnel
Hashtable. However, it appears they are being added somewhere, or there is another underlying issue I couldn't spot.Given the nature of this problem, I recommend that someone with more experience review the
ResolveScenarioTracker.java
code. This type of error could potentially lead to more significant problems in the future.