Fixed Award Image Display in Person View #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each graduateCaste method in the EducationController has been adjusted to include a return statement following the method call, thereby preventing the execution of multiple graduateCaste calls within a single instance. The update ensures process efficiency and eliminates potential errors caused by unintended multiple gradations.
…rd image calculations
… for award image calculations" This reverts commit 0eba5f0.
…rd image calculations
…bons, medals, and misc awards
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4115 +/- ##
============================================
- Coverage 10.54% 10.28% -0.27%
- Complexity 5605 5732 +127
============================================
Files 886 913 +27
Lines 117416 123696 +6280
Branches 17617 18390 +773
============================================
+ Hits 12383 12720 +337
- Misses 103774 109710 +5936
- Partials 1259 1266 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another quick fix to the display of award ribbons, medals, and miscs in the person view panel. My previous fix appeared to resolve the issue, but instead it failed whenever 'person' had more than one issuance of the award. This adds better bounds by using the
MathUtility.clamp().