Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handle multiple personnel This commit is refactoring the automatic awards tracking system to handle multiple personnel at once, rather than one-by-one. This is achieved by changing the person parameter to a HashMap of UUID and injury counts on the AutoAwardsController's PostScenarioController. The commit also adjusts associated methods to handle the HashMap data and consolidates the retrieval of kills within methods where necessary.
HammerGS
added a commit
that referenced
this pull request
May 25, 2024
MegaMek + Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively MegaMekLab + Fix ##1514: Fix Atrocious table shading render speed MekHQ + PR #4106: Use tabs in customize scenario dialog + PR #4105: Updated Post-Scenario Logging for Prisoners + PR #4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards + PR #4102: Fixed Award Tier Count Calculations in PersonViewPanel + PR #4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel + PR #4054: Added Life Paths Campaign Options Tab, Added Education Module Very Important to read the documentation on this feature (See Docs folder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the automatic awards tracking system to handle multiple personnel simultaneously, instead of one-by-one. This is achieved by changing the
personparameter to aHashMapof UUIDs and injury counts in theAutoAwardsController'sPostScenarioController. Associated methods have been adjusted to handle theHashMapdata, and the retrieval of kills has been consolidated within methods where necessary.This resolves a bug discovered by our QA team, where faulty logic was causing auto-awards to trigger multiple times during post-scenario conditions.