Updated isChild() #4041
Merged
Updated isChild() #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'isChild' method in the Person class has been updated to consider anyone aged 18 or below as a child, as opposed to the previous age limit of 13.
SJuliez
requested changes
May 12, 2024
|
Potentially, I’ll take a proper look tomorrow.Sent from my iPhoneOn May 12, 2024, at 10:21 AM, SJuliez ***@***.***> wrote:
@SJuliez requested changes on this pull request.
In MekHQ/src/mekhq/campaign/personnel/Person.java:
@@ -1121,7 +1121,7 @@ public UUID getId() {
}
public boolean isChild(final LocalDate today) {
- return getAge(today) <= 13;
+ return getAge(today) <= 18;
I guess that should be < 18, right?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: ***@***.***>
|
The age check logic in the Person class has been updated. Previously, individuals up to and including 18 were considered children; this has now been revised, the condition now considers individuals as children if they are less than 18.
SJuliez
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We utilize a check called
isChild()primarily within the mhq reproduction system. Currently, it defines anyone aged 14 or older as an adult eligible for reproduction.Following a discussion with Hammer, we have decided to raise this age threshold to 18. Although there are instances of 14-year-old parents in reality, we concluded that such scenarios do not contribute positively to mhq.