Fixed Ship Search Overvaluing Ultra-Green Personnel

[IllianiCBT]

Current Implementation

AtB Ship Search currently uses a block of code to cycle through each logistics personnel, with a mind towards finding the best personnel skill rating among logistics personnel. It then uses this to apply a modifier to the Ship Search TN.

Problem

The code already checks for highest skilled personnel using the findBestInRole() function. The loop that follows is unnecessary.

Furthermore, the loop includes broken logic that results in Ultra-Green personnel being rated higher than any other personnel.

Solution

I simply removed the excess code.

Testing

I tested personnel with both primary and secondary Admin/Logistics roles of all ranks.

...closes #3989

[Sleet01]

LGTM!

Would it be difficult to add a unit test showing that this function no longer overvalues Ultra Green admins?

[IllianiCBT]

LGTM!

Would it be difficult to add a unit test showing that this function no longer overvalues Ultra Green admins?

Being perfectly honest, I have no idea where to even start with Unit Tests

[Sleet01]

LGTM!
Would it be difficult to add a unit test showing that this function no longer overvalues Ultra Green admins?

Being perfectly honest, I have no idea where to even start with Unit Tests

No worries, although now I think we might want to have a Unit Test page in the Wiki at some point.
It's basically just calling the changed code as locally (that is, as close to the change) as possible, with any required information or data mocked up or initialized so the code works as per normal.