Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CamOps Unit Rating Handling Within Clamp #3980

Merged
merged 2 commits into from
May 12, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Current Implementation

Currently we clamp CamOps unit rating within the bounds of the FM:F (F-A*) rating system.

Problem

While my earlier fix addressed the issue of CamOps unit rating modifiers breaking a bunch of things (see #3933), there is still the issue of the CamOps Unit Rating method resulting reaching the maximum/minimum modifier faster than expected - from a balancing point of view.

Solution

Dividing the CamOps unit rating by 3 produces closer results to the equivalent FM:M rating. It's not an ideal solution, but it resolves the biggest issues.

@HammerGS HammerGS merged commit bd2337e into MegaMek:master May 12, 2024
4 checks passed
HammerGS added a commit that referenced this pull request May 12, 2024
+ PR #4037: Better Randomness in BotForceRandomizer
+ PR #4026: Refactor ChoiceStoryPoint and NarrativeStoryPoint with underlying abstract DialogStoryPoint class
+ PR ##3980: Improved CamOps Unit Rating Handling Within Clamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants