Added Nag Dialog for Exceeding Cargo Capacity While Destination is Set #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3969 +/- ##
============================================
- Coverage 10.65% 10.65% -0.01%
Complexity 5536 5536
============================================
Files 841 842 +1
Lines 114411 114429 +18
Branches 17209 17211 +2
============================================
Hits 12189 12189
- Misses 100992 101010 +18
Partials 1230 1230 ☔ View full report in Codecov by Sentry. |
SJuliez
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Implementation
None
Problem
Currently it is easy to exceed cargo capacity, unless you are watching your maximum cargo capacity like a hawk.
Solution
If the user has set a destination on the interstellar map, this nag will trigger in the event that current cargo tonnage exceeds cargo capacity. I opted to disable the check when no destination is set, as I figured while the user is on-planet there is no need to remain within cargo capacity.
Notes
This is definitely a nag I don't expect all users will appreciate, however the ease with which this nag can be suppressed seemed to warrant its inclusion for those users who do try to keep cargo within capacity.
Ideally, this nag would start suppressed on a new campaign, however I couldn't figure out how to enable that functionality. If that functionality does exist, and someone can point me towards it, it would empower me to add more niche nags like this, in future.